Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add capability to disable address-only for connectivity monitors #3867

Merged

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Apr 16, 2024

Change Summary

Important

You need a very recent engineering version of EOS to test - this is not yet released.

This PR is required for WAN Internet Exit configuration towards SWG

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Add a boolean address_only in the four places where it can now be disabled
  • Set the boolean to true by default to be backward compatible
    • In AVD 5.0 we may decide to make it default False -> this needs to be tracked as a 5.0 issue if we decide so
  • Exercise the new knob in 3 of the four places - can make it work as well in the last one but requires an extra host in eos_cli_config_gen molecule.

How to test

molecule

Checklist

Reviewer Checklist

  • For documentation, rather than adding a template we could decide to add (address-only) in the local interfaces cell when this is configured and nothing otherwise, if the reviewer feels strongly about this, we can change that. -> NO

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested by generating the .cfg files.

@gmuloc gmuloc merged commit 668700a into aristanetworks:devel Apr 16, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants