Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suport jest v24 #196

Merged
merged 5 commits into from
Feb 13, 2019
Merged

suport jest v24 #196

merged 5 commits into from
Feb 13, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Feb 2, 2019

Summary

  • Upgrade jest@24 and babel-jest@24
  • Remove babel-core bridge
  • Use setupFilesAfterEnv instead of setupTestFrameworkScriptFile
  • Update Readme

Test plan

  • npm run test:incognito running normally
  • CRA example running normally

@xiaoyuhen
Copy link
Contributor Author

Because Jest@24 has some bug, we are unable to support it for the time being.
see jestjs/jest#7724

We will merge this PR as soon as possible after the jest fix version release. cc @Greg-oliver99 @RoiEXLab

@gregberge
Copy link
Member

@xiaoyuhen we can't do that. If we do, the project will only work with Jest v24+. I think we should wait a little before doing it.

@xiaoyuhen
Copy link
Contributor Author

@neoziro

yeah, we need to wait until jest@24 is stable before considering support.

If we consider supporting jest v24, maybe we need to release a 4.x version. The jest-puppeteer 3.x version supports jest v22~23, and the 4.x version supports jest v24+.

@gregberge
Copy link
Member

@xiaoyuhen could you fix tests? I would like to release a new major this week with Jest 24 support.

@xiaoyuhen
Copy link
Contributor Author

@neoziro

The travis-ci has this error

error sane@3.1.0: The engine "node" is incompatible with this module. Expected version "6.* || 8.* || >= 10.*".

see https://travis-ci.org/smooth-code/jest-puppeteer/jobs/491494756#L515

Should we remove the support of node 9?

@gregberge
Copy link
Member

@xiaoyuhen yeah, please add support only for node 8 & 10. v9 should not be used.

@xiaoyuhen xiaoyuhen changed the title WIP: suport jest@24 suport jest v24 Feb 11, 2019
@xiaoyuhen
Copy link
Contributor Author

@neoziro

Support for the jest v24 has been completed. If there are any suggestions, please let me know.

@gregberge
Copy link
Member

Thanks!

@tirithen
Copy link

Sitting on edge for the npm publish, can't wait. ;) Thanks, for a nice package, soon I can run my tests again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants