build(docs): set site_url from ReadTheDocs env var
#13685
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `site_url` is [required](https://stackoverflow.com/a/59295885/3431180) for canonicalization and creating a `sitemap.xml` - Also for certain features like: - Instant loading: https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/?h=site+url#instant-loading - Versioning (we use RTD's versioning, but may want some features from here): https://squidfunk.github.io/mkdocs-material/setup/setting-up-versioning/?h=site+url#publishing-a-new-version Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
site_urlis required for canonicalization and creating asitemap.xmlAlso for certain features like:
Modifications
site_urlconfig tomkdocs.ymlVerification
tbd still need to test this