Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(cli): add example for argo archive delete #13675

Merged
merged 6 commits into from
Sep 30, 2024
Merged

docs(cli): add example for argo archive delete #13675

merged 6 commits into from
Sep 30, 2024

Conversation

leehosu
Copy link
Contributor

@leehosu leehosu commented Sep 29, 2024 •
edited by agilgur5
Loading

Fixes #11898

Motivation

Modify the argo archive delete command for more information

Modifications

Added example for the argo archive delete command.

Verification

run argo archive delete -h

@leehosu
docs(cli): add examples for argo archive delete with option explanations
377affe 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
Commit to resolving codegen
070366f 
Signed-off-by: leehosu <hosu4549@gmail.com>
@leehosu
refactor : Modify about expalins
0cdf16b 
Signed-off-by: leehosu <hosu4549@gmail.com>
@blkperl blkperl added the area/docs Incorrect, missing, or mistakes in docs label Sep 30, 2024
@agilgur5 agilgur5 added the area/cli The `argo` CLI label Sep 30, 2024
@agilgur5 agilgur5 changed the title docs(cli): add examples for argo archive delete with option explanations docs(cli): add example for argo archive delete Sep 30, 2024
agilgur5
agilgur5 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the title of the PR as there is only a singular example and no options here. Please modify any similar PRs to match.

Otherwise LGTM, the comment does add more than the short description has

@agilgur5 agilgur5 merged commit 2c3423e into argoproj:main Sep 30, 2024
29 checks passed
@agilgur5 agilgur5 mentioned this pull request Sep 30, 2024
Open
42 tasks
@leehosu leehosu mentioned this pull request Oct 1, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples to commands' --help output
3 participants
@leehosu @agilgur5 @blkperl