fix(controller): node message should be updated when lock msg changed

[chengjoey]

Fixes #13629

Motivation

When the sync lock is not released, the latest lock-msg is always used as the node message

[chengjoey]

/hold
add test

[chengjoey]

/hold cancel

[MasonM]

@chengjoey FYI: I entered #13660 to fix the flaky tests. After that's merged, click the "Update branch" button at the bottom of the PR

[Joibel]

/hold cancel

@chengjoey is this ready for review, I'm unsure of what you meant by this comment?

[chengjoey]

/hold cancel

@chengjoey is this ready for review, I'm unsure of what you meant by this comment?

yeah, it is ready for review, since I didn't add the test at first, I used /hold cancel to get ready after adding the test

[Joibel]

As a follow up to this it would be possible to list all of the failing locks rather than just the first, so if you feel like doing that it would be useful.

[Joibel]

This feels wrong for a test.

Surely the outcome of TryAquire should always be the same for this test, and therefore we could assert that !lockAcquired? If lockAquired is true here we're not testing the new functionality.

[chengjoey]

done~, I modified the test case and handed over the modification of msg and status to operate