-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): handle multi-resource yaml in offline lint. Fixes #12137 #13531
base: main
Are you sure you want to change the base?
fix(cli): handle multi-resource yaml in offline lint. Fixes #12137 #13531
Conversation
…oproj#12137 Signed-off-by: Wang, Wayne <Wayne.Wang@fmr.com>
…-issue-on-multi-documents-yaml-file
Signed-off-by: Wang, Wayne <Wayne.Wang@fmr.com>
693db02
to
70c5e90
Compare
@miltalex do you want to try reviewing this? Since you've worked on |
I'm curious if this also fixes #10608? |
I would be happy to review it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you very much for submitting the fix. I have a small stylistic suggestion otherwise LGTM
Signed-off-by: Wang, Wayne <Wayne.Wang@fmr.com>
Signed-off-by: Wang, Wayne <Wayne.Wang@fmr.com>
/retest |
Fixes #12137
Fixes #10608
Motivation
If there are multiple templates in one yaml file. The
argo lint --offline
can only get the first template.Because the
yaml.Unmarshal
function is used to parse a single YAML document.Modifications
Read yaml file with
common.ParseObjects
in offline mode.Verification
e2e test.
argo lint --offline test.yaml
Add unittest case.