docs(security): add Draft GHSA option #12747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for ease of use, built-in templates, crediting, single source of truth, etc - as well as consistency with CD: https://github.com/argoproj/argo-cd/blob/a4b50515381bad9d6db316d49d33efae351c6222/SECURITY.md?plain=1#L68 Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/security
Closed
terrytangyuan
approved these changes
Apr 4, 2024
4 tasks
agilgur5
added a commit
that referenced
this pull request
May 4, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> (cherry picked from commit f521c30)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12745
Motivation
Modifications
SECURITY.md(we already have email), which is using draft GHSAs.Verification
See the rendered markdown in this PR
Notes to Reviewers
Do not merge until Draft GHSAs are enabled by an admin, i.e. until this link works: https://github.com/argoproj/argo-workflows/security/advisories/new
For clarity and explicitness, draft GHSAs are not equivalent to CVEs. If a draft GHSA is determined to be an active vuln (as opposed to false positive etc), then a CVE can be assigned. It is just another method of private disclosure, one that keeps things consistent and in the same place as public disclosures.