Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgrade axios to v1.6.0. Fixes #12085 #12111

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: Upgrade axios to v1.6.0. Fixes #12085 #12111

merged 3 commits into from
Oct 31, 2023

Conversation

terrytangyuan
Copy link
Member

Fixes #12085.

@terrytangyuan
fix: Upgrade axios to v1.6.0. Fixes argoproj#12085
d6e688a 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan mentioned this pull request Oct 31, 2023
Closed
agilgur5
agilgur5 requested changes Oct 31, 2023
View reviewed changes
ui/package.json Outdated Show resolved Hide resolved
ui/yarn.lock Outdated Show resolved Hide resolved
@agilgur5 agilgur5 added type/security Security related type/dependencies PRs and issues specific to updating dependencies javascript Pull requests that update Javascript dependencies labels Oct 31, 2023
@agilgur5
Copy link
Member

So it looks like this was a breaking change: axios/axios#6028 (comment)
Per previous comment, I don't think a cookie is needed for the API docs, but could you check to confirm that it still works?

Also I might recommend fix(deps): Update transitive axios to v1.6.0 for the title to be a bit more specific as it's not a dep we use directly

@agilgur5
Copy link
Member

but could you check to confirm that it still works?

Checked myself, seems to work fine. So I think this is good to go once the suggested changes are made

terrytangyuan and others added 2 commits October 31, 2023 07:11
@terrytangyuan @agilgur5
Update ui/package.json
787fd0a 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
@terrytangyuan @agilgur5
Update ui/yarn.lock
d5b6f09 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan merged commit f200826 into argoproj:master Oct 31, 2023
15 checks passed
@terrytangyuan terrytangyuan deleted the fix-axiom branch October 31, 2023 11:35
This was referenced Oct 31, 2023
Open
Open
terrytangyuan added a commit that referenced this pull request Nov 3, 2023
@terrytangyuan @agilgur5
fix: Upgrade axios to v1.6.0. Fixes #12085 (#12111)
2a044bf 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
terrytangyuan added a commit that referenced this pull request Nov 3, 2023
@terrytangyuan @agilgur5
fix: Upgrade axios to v1.6.0. Fixes #12085 (#12111)
9e04496 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@terrytangyuan @agilgur5 @dpadhiar
fix: Upgrade axios to v1.6.0. Fixes argoproj#12085 (argoproj#12111)
f77d6a4 
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan (Terry) Tang <terrytangyuan@gmail.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 requested changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies type/security Security related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New vulnerability detected in Node dependency axios
2 participants
@terrytangyuan @agilgur5