Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added example support for artifact command in root.go (#11898) #11933

Closed
wants to merge 2 commits into from
Closed

feat: added example support for artifact command in root.go (#11898) #11933

wants to merge 2 commits into from

Conversation

nikzayn
Copy link

@nikzayn nikzayn commented Oct 3, 2023

Yes, it fixes by adding the example support for the artifact command.

Fixes #11898

Motivation

I have made my changes to support more detailed information when someone triggers or runs artifact cobra command.

Verification

by running - argo artifact my-wf

@nikzayn
feat: added example support for artifact command in root.go (argoproj…
eecce33 
…#11898)

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
terrytangyuan
terrytangyuan reviewed Oct 3, 2023
View reviewed changes
cmd/argoexec/commands/artifact/root.go Outdated
Use: "artifact",
Use: "artifact",
Short: "Implement a new artifact",
Example: `# Initialize a workflow for new artifact:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a workflow.

cmd/argoexec/commands/artifact/root.go Outdated Show resolved Hide resolved
@nikzayn
feat: updated the example message for cobra command
7e1f8d7 
Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
@agilgur5 agilgur5 added the area/cli The `argo` CLI label Oct 4, 2023
@rum1887
Copy link

rum1887 commented Oct 6, 2023 •
edited
Loading

hey, U could run the pre-commit hooks without facing protoc-gen-gogo plugin not found error?

I get the following error when I try to run make pre-commit -B

topological order github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1 2023/10/06 19:13:33 protoc-gen-gogo: program not found or is not executable

Please specify a program using absolute path or make sure the program is available in your PATH system variable --gogo_out: protoc-gen-gogo: Plugin failed with status code 1. 2023/10/06 19:13:33 protoc -I . -I /Users/ramya/go/src -I /Users/ramya/go/src --gogo_out=/Users/ramya/go/src /Users/ramya/go/src/k8s.io/apimachinery/pkg/util/intstr/generated.proto 2023/10/06 19:13:33 Unable to generate protoc on k8s.io.apimachinery.pkg.util.intstr: exit status 1 make: *** [pkg/apis/workflow/v1alpha1/generated.proto] Error 1

I added the dir of protoc-gen-gogo to the PATH variable, the error still persists

@rum1887
Copy link

rum1887 commented Oct 10, 2023 •
edited
Loading

@nikzayn You'll have to push the doc/cli file as well

@agilgur5 agilgur5 added problem/stale This has not had a response in some time problem/more information needed Not enough information has been provide to diagnose this issue. labels Oct 12, 2023
@juliev0
Copy link
Contributor

juliev0 commented Dec 8, 2023

closing due to staleness

@juliev0 juliev0 closed this Dec 8, 2023
@agilgur5 agilgur5 added solution/invalid This is incorrect. Also can be used for spam and removed problem/stale This has not had a response in some time problem/more information needed Not enough information has been provide to diagnose this issue. labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

Assignees
No one assigned
Labels
area/cli The `argo` CLI solution/invalid This is incorrect. Also can be used for spam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add examples to commands' --help output
5 participants
@nikzayn @rum1887 @juliev0 @terrytangyuan @agilgur5