fix: flakey TestWriteBackToInformer test #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Codecov ReportBase: 81.50% // Head: 81.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2621 +/- ##
==========================================
+ Coverage 81.50% 81.52% +0.01%
==========================================
Files 131 131
Lines 19562 19562
==========================================
+ Hits 15944 15947 +3
+ Misses 2798 2795 -3
Partials 820 820
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
leoluz
reviewed
Feb 23, 2023
leoluz
reviewed
Feb 23, 2023
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the flakey unit test
TestWriteBackToInformerI was able to easily reproduce the flake buy putting the test into a loop, when I switched out the code to use json marshaling it 3000 iterations passed.This is possibly somewhat a hack solution for how we are using the fake client with informers. There could also be a bug upstream in k8s fake client.