Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: manually run auto changelog and fix workflow #2494

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Dec 20, 2022

Fixes the workflow to use the right binary os and do a manually run for 1.4.0-rc1

Signed-off-by: zachaller zachaller@users.noreply.github.com

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 81.67% // Head: 81.68% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (56f6725) compared to base (f5fb4c4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2494   +/-   ##
=======================================
  Coverage   81.67%   81.68%           
=======================================
  Files         126      126           
  Lines       19124    19132    +8     
=======================================
+ Hits        15620    15628    +8     
  Misses       2710     2710           
  Partials      794      794           
Impacted Files Coverage Δ
utils/replicaset/canary.go 92.85% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zachaller zachaller changed the title fix: manually run auto changelog and fix workflow build: manually run auto changelog and fix workflow Dec 20, 2022
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment

@@ -0,0 +1,203 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a CHANGELOG.md in root folder. I don't think it is a good idea to have 2 changelog files. Maybe I am misunderstanding the strategy behind this new file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the old CHANGELOG was a manually created file. That dose not really make sense to maintain I had wanted to see how well the auto generated changelog tooling worked for a while before removing and/or deprecating the old CHANGELOG.md. If you think we should just do that now we can. One issue though is that the auto generated tooling replaces the whole file each time, so if we wanted to keep the old one we would need to rename it something like CHANGELOG-v0.1.0-v1.1.0.md or something like that and then just have the new auto generated stuff go into CHANGELOG.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will also point out slightly this first run for 1.4 is also not 100% perfect because sematic pr titles where note enabled for all of it so there is a few wrong headings etc but going forward it should be reallly good.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the old one makes sense to me. I agree that the new file should be just CHANGELOG.md.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good let me update

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Go Published Test Results

1 833 tests   1 833 ✔️  2m 30s ⏱️
   105 suites         0 💤
       1 files           0

Results for commit 56f6725.

@github-actions
Copy link
Contributor

E2E Tests Published Test Results

    2 files      2 suites   1h 34m 58s ⏱️
  94 tests   89 ✔️ 3 💤 2
192 runs  182 ✔️ 6 💤 4

For more details on these failures, see this check.

Results for commit 56f6725.

@zachaller zachaller merged commit b12b673 into argoproj:master Dec 20, 2022
zachaller added a commit that referenced this pull request Jan 10, 2023
* fix: manually run auto changelog and fix workflow

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix: add workflow changes

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* change name on old CHANGELOG and make autogen primary

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* fix: manually run auto changelog and fix workflow

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix: add workflow changes

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* change name on old CHANGELOG and make autogen primary

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
tperdue321 pushed a commit to rallyhealth/argo-rollouts that referenced this pull request Jan 12, 2023
* fix: manually run auto changelog and fix workflow

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* fix: add workflow changes

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

* change name on old CHANGELOG and make autogen primary

Signed-off-by: zachaller <zachaller@users.noreply.github.com>

Signed-off-by: zachaller <zachaller@users.noreply.github.com>
Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants