Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update golang to v1.14.12 [backport to release-1.7] #4834

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Nov 15, 2020

Back-port of #4832 against release-1.7 branch.

Signed-off-by: jannfis jann@mistrust.net

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
@jannfis jannfis marked this pull request as draft November 15, 2020 18:11
Signed-off-by: jannfis <jann@mistrust.net>
@codecov-io
Copy link

Codecov Report

Merging #4834 (8e516e6) into release-1.7 (ad4b60a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.7    #4834   +/-   ##
============================================
  Coverage        41.07%   41.07%           
============================================
  Files              124      124           
  Lines            16577    16577           
============================================
  Hits              6809     6809           
  Misses            8786     8786           
  Partials           982      982           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4b60a...8e516e6. Read the comment docs.

@jannfis
Copy link
Member Author

jannfis commented Nov 15, 2020

Codegen step fails because of image tag in manifests (tag in branch vs. latest), should be fine.

@jannfis jannfis marked this pull request as ready for review November 15, 2020 19:10
@jannfis jannfis requested a review from alexmt November 15, 2020 19:10
@alexmt alexmt merged commit 2e8751c into argoproj:release-1.7 Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants