Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login with apiKey capability #4557

Merged
merged 4 commits into from
Oct 14, 2020

Conversation

mayzhang2000
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Fixes: #4542

util/session/sessionmanager.go Outdated Show resolved Hide resolved
util/session/sessionmanager.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #4557 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4557      +/-   ##
==========================================
- Coverage   41.44%   41.44%   -0.01%     
==========================================
  Files         123      123              
  Lines       16809    16815       +6     
==========================================
+ Hits         6967     6969       +2     
- Misses       8837     8839       +2     
- Partials     1005     1007       +2     
Impacted Files Coverage Δ
util/session/sessionmanager.go 64.91% <0.00%> (-0.58%) ⬇️
util/settings/settings.go 40.49% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f512d21...ad60a67. Read the comment docs.

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too. And sorry again for confusion.

@mayzhang2000 mayzhang2000 merged commit 23ac24b into argoproj:master Oct 14, 2020
@mayzhang2000
Copy link
Contributor Author

Thank you @jannfis and @alexmt for your review!

mayzhang2000 added a commit that referenced this pull request Oct 14, 2020
* fix: login with apiKey capability

* fix: update based on code review.

* fix: update based on code review.

* fix: check pws first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can login to ArgoCD UI even if user is created as apiKey only
4 participants