-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: login with apiKey capability #4557
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4557 +/- ##
==========================================
- Coverage 41.44% 41.44% -0.01%
==========================================
Files 123 123
Lines 16809 16815 +6
==========================================
+ Hits 6967 6969 +2
- Misses 8837 8839 +2
- Partials 1005 1007 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too. And sorry again for confusion.
* fix: login with apiKey capability * fix: update based on code review. * fix: update based on code review. * fix: check pws first.
Checklist:
Fixes: #4542