Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logging.go): changing marshaler for JSON logging to use gogo #4319

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

igaskin
Copy link
Member

@igaskin igaskin commented Sep 14, 2020

grpc-gateway json marshaler breaks with gogo protos

#4117

This issue is related to gogo/protobuf#212 (comment)

argocd cli

$ argocd proj create foo
EE: 0/[]

argocd server corrected output

{"grpc.code":"OK","grpc.method":"Create","grpc.service":"project.ProjectService","grpc.start_time":"2020-09-13T19:41:03-07:00","grpc.time_ms":15.292,"level":"info","msg":"finished unary call with code OK","span.kind":"server","system":"grpc","time":"2020-09-13T19:41:03-07:00"}

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • I've signed the CLA and my build is green (troubleshooting builds).

grpc-gateway json marshaler breaks with gogo protos

argoproj#4117
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #4319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4319   +/-   ##
=======================================
  Coverage   42.77%   42.77%           
=======================================
  Files         124      124           
  Lines       18411    18411           
=======================================
  Hits         7876     7876           
  Misses       9517     9517           
  Partials     1018     1018           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ee234...c788649. Read the comment docs.

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayzhang2000 mayzhang2000 merged commit 4e6d8cc into argoproj:master Sep 14, 2020
@igaskin igaskin deleted the user/igaskin/4117 branch September 19, 2020 06:51
@jessesuen jessesuen added the cherry-pick/1.7 Candidate for cherry picking into the 1.7 release branch label Oct 15, 2020
alexmt pushed a commit that referenced this pull request Oct 15, 2020
* fix(logging.go): changing marshaler for JSON logging to use gogo

grpc-gateway json marshaler breaks with gogo protos

#4117

* Retrigger CI pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/1.7 Candidate for cherry picking into the 1.7 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants