Support canary services in multiple routes of the same proxy #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given an HTTPProxy template that looks like the following:
```
spec:
routes:
- conditions:
- prefix: /foo
services:
- name: web
weight: 100
- name: web-canary
weight: 0
- conditions:
- prefix: /bar
services:
- name: web
weight: 100
- name: web-canary
weight: 0
```
Previously we would only update the weights of one of the routes, now
we will update all the routes for the appropriate canary
Signed-off-by: Frank Hamand <frankhamand@gmail.com>
frankh
force-pushed
the
support-multiple-routes
branch
from
3405407
to
8935dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #75
What this PR does / why we need it:
Given an HTTPProxy template that looks like the following:
Previously we would only update the weights of one of the routes, now we will update all the routes for the appropriate canary
Special notes for your reviewer:
If applicable: