feature: use patch strategy to update services weight #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this good feature, @izturn please help to review. |
izturn
reviewed
Dec 28, 2023
Signed-off-by: yyzxw <1020938856@qq.com>
yyzxw
force-pushed
the
feat/patch-weight
branch
from
d07de9d
to
bdabf9b
Compare
|
@wilsonwu PTAL |
|
@yyzxw LGTM, thx |
frankh
added a commit
to frankh/argo-helm
that referenced
this pull request
Jan 25, 2024
Since this PR argoproj-labs/rollouts-plugin-trafficrouter-contour#53 the contour trafficrouter plugin uses `patch` not `update`. Add the `patch` permission so that the latest version of the trafficrouter plugin works Signed-off-by: Frank Hamand <frankhamand@gmail.com>
frankh
added a commit
to frankh/argo-helm
that referenced
this pull request
Jan 25, 2024
Since this PR argoproj-labs/rollouts-plugin-trafficrouter-contour#53 the contour trafficrouter plugin uses `patch` not `update`. Add the `patch` permission so that the latest version of the trafficrouter plugin works Signed-off-by: Frank Hamand <frankhamand@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
use patch strategy to update services weight to avoid strongly dependent versions of contour.
Special notes for your reviewer:
If applicable: