Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider all HTTPProxy route services #16

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

mvgmb
Copy link
Contributor

@mvgmb mvgmb commented May 16, 2023

Closes #15

Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
@mvgmb mvgmb changed the title Consider all HTTPProxy routes when listing services Consider all HTTPProxy route services May 16, 2023
@wilsonwu
Copy link
Collaborator

@izturn could you please help to review, thanks!

pkg/plugin/plugin.go Outdated Show resolved Hide resolved
Signed-off-by: Mario Bezerra <mario.bezerra@incognia.com>
@izturn
Copy link
Collaborator

izturn commented Jul 12, 2023

LGTM pls fix the conflicts first

Copy link
Collaborator

@izturn izturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@izturn izturn merged commit bbfbd96 into argoproj-labs:main Jul 17, 2023
2 checks passed
@mvgmb mvgmb deleted the fix/list-services branch July 18, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to find service in HTTPProxy with more than one route
3 participants