Apply suggestions from code review

Co-authored-by: izturn <44051386+izturn@users.noreply.github.com>
argoproj-labs · Sep 6, 2023 · 7bff54a · 7bff54a
1 parent 3a6f412
commit 7bff54a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pkg/mocks/plugin.go b/pkg/mocks/plugin.go
@@ -13,7 +13,7 @@ const (
 
 	HTTPProxyName               = "argo-rollouts"
 	ValidHTTPProxyName          = "argo-rollouts-valid"
-	OutdatedHTTPProxy           = "argo-rollouts-outdated"
+	OutdatedHTTPProxyName           = "argo-rollouts-outdated"
 	InvalidHTTPProxyName        = "argo-rollouts-invalid"
 	FalseConditionHTTPProxyName = "argo-rollouts-false-condition"
 
@@ -65,7 +65,7 @@ func MakeObjects() []runtime.Object {
 	return objs
 }
 
-func newValidHttpProxy(name string) *contourv1.HTTPProxy {
+func newHTTPProxy(name string) *contourv1.HTTPProxy {
 	return &contourv1.HTTPProxy{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:       name,

diff --git a/pkg/plugin/plugin.go b/pkg/plugin/plugin.go
@@ -129,7 +129,7 @@ func (r *RpcPlugin) Type() string {
 	return Type
 }
 
-func (r *RpcPlugin) getHttpProxy(ctx context.Context, namespace string, name string) (*contourv1.HTTPProxy, error) {
+func (r *RpcPlugin) getHTTPProxy(ctx context.Context, namespace string, name string) (*contourv1.HTTPProxy, error) {
 	unstr, err := r.dynamicClient.Resource(contourv1.HTTPProxyGVR).Namespace(namespace).Get(ctx, name, metav1.GetOptions{})
 	if err != nil {
 		return nil, err