[FEATURE] [SDK] chat field support sdk #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
| @@ -31,11 +31,12 @@ class ImageFieldSettings(BaseModel): | |||
| type: Literal["image"] = "image" | |||
|
|
|||
|
|
|||
| class ChatFieldSettings(BaseModel): | |||
| type: Literal["chat"] = "chat" | |||
There was a problem hiding this comment.
do we want to include something like user_role, assitant_role?
There was a problem hiding this comment.
I don't think that's necessary for the first iteration. But it would be nice for a later iteration where we allow the user to define the 'chat schema' based on their own data.
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
…rgilla-io/argilla into feat/chat-field-support-server
for more information, see https://pre-commit.ci
Base automatically changed from
feat/chat-field-support-server
to
feat/chat-field-support
August 8, 2024 11:34
There was a problem hiding this comment.
Hi @burtenshaw, looking good. I think we might want to add this to the from/to/disk/hub methods too.
Sorry @davidberenstein1957 . I don't get this one. How would we add this to those methods? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements chat field support on the SDK.
Type of change
How Has This Been Tested
Checklist