improvement: add some SQLite pragma statement settings to improve performance #5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to imp…" This reverts commit 3512cbd.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5192 +/- ##
========================================
Coverage 91.12% 91.13%
========================================
Files 139 139
Lines 5816 5821 +5
========================================
+ Hits 5300 5305 +5
Misses 516 516
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…qlite-pragma-to-improve-performance
|
We should check these improvements in HF Spaces removing all the WAL-related ones. |
…qlite-pragma-to-improve-performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After suffering general slowness in HF spaces after merging the SQLite fine tuning changes I have reverted the changes so we can focus on distribution task changes.
After that we will investigate if these changes are the source of the slowness with HF Spaces using persistent storage or not.
Reverts #5191