Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [REFACTOR] argilla-server: move search logic to search service #5174

Draft
wants to merge 14 commits into
base: refactor/argilla-server/list-records-endpoint-using-db
Choose a base branch
from

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jul 6, 2024

Description

This PR cleans and moves all logic from search endpoint handlers to a Search service.

Update

The code will probably be moved to under the search context module.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon changed the base branch from refactor/argilla-server/move-search-validator-to-proper-module to refactor/argilla-server/list-records-endpoint-using-db July 19, 2024 06:59
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 98.43750% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.09%. Comparing base (bca45ff) to head (edc0fe0).

Files Patch % Lines
...gilla-server/src/argilla_server/services/search.py 97.72% 2 Missing ⚠️
...lla-server/src/argilla_server/validators/search.py 98.41% 1 Missing ⚠️
Additional details and impacted files
@@                                    Coverage Diff                                     @@
##           refactor/argilla-server/list-records-endpoint-using-db    #5174      +/-   ##
==========================================================================================
- Coverage                                                   91.22%   91.09%   -0.14%     
==========================================================================================
  Files                                                         142      144       +2     
  Lines                                                        5746     5793      +47     
==========================================================================================
+ Hits                                                         5242     5277      +35     
- Misses                                                        504      516      +12     
Flag Coverage Δ
argilla-server 91.09% <98.43%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon added this to the v2.1.0 milestone Jul 19, 2024
@frascuchon frascuchon added the type: refactor Indicates internal refactoring of the code-base label Jul 19, 2024
… into refactor/argilla-server/move-search-logic-to-search-service
@frascuchon frascuchon marked this pull request as ready for review July 25, 2024 07:23
@frascuchon frascuchon requested a review from jfcalvo July 25, 2024 07:23
@frascuchon frascuchon marked this pull request as draft July 25, 2024 07:23
… into refactor/argilla-server/move-search-logic-to-search-service
… into refactor/argilla-server/move-search-logic-to-search-service
@frascuchon frascuchon modified the milestones: v2.1.0, v2.2.0 Sep 3, 2024
@frascuchon frascuchon changed the title [REFACTOR] argilla-server: move search logic to search service [DRAFT] [REFACTOR] argilla-server: move search logic to search service Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Indicates internal refactoring of the code-base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant