-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT/REFACTOR] argilla
: lazy resolution for dataset workspaces
#5152
[ENHANCEMENT/REFACTOR] argilla
: lazy resolution for dataset workspaces
#5152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question: how would Dataset.exist
behave if there's no workspace in the dataset resource? This method confuses a lot of users.
The maybe this existence method should be defined at the client level: client.datasets.exists(dataset)
#or
client.datasets.exists(name, workspace) Just to force a direct client interaction to make more sense to the "exists" query. |
Yeah. I think this would solve it because in most cases the user just wants to know 'can I use this name?' This could be implemented in a subsequent PR though. |
This PR removes the workspace resolution on
Dataset.__init__
and performs it lazily when creating datasets or accessing thedataset.workspace
propertyType of change
How Has This Been Tested
Checklist