Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR]: argilla: Rename status to response.status for filtering using the SDK #5145

Merged
merged 3 commits into from
Jul 4, 2024
Merged

[REFACTOR]: argilla: Rename status to response.status for filtering using the SDK #5145

merged 3 commits into from
Jul 4, 2024

Conversation

frascuchon
Copy link
Member

This PR renames the status key to response.status for filtering with the SDK.

Type of change

  • Refactor (change restructuring the codebase without changing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon
refactor: Rename status to response.status for filters
8e777cb 
Also, some of the model properties have been renamed to  api_model methods
@frascuchon frascuchon merged commit 239d6b1 into develop Jul 4, 2024
7 checks passed
@frascuchon frascuchon deleted the refactor/rename-status-to-responses.status branch July 4, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtenshaw burtenshaw burtenshaw approved these changes

@nataliaElv nataliaElv nataliaElv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frascuchon @burtenshaw @nataliaElv