-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve get pop issues #5135
Conversation
Thanks @sdiazlor ! Everything looks good. I just don't understand very well why planned issues need to be filtered by "v2". I think this might make the code difficult to maintain in the future, although it might work for now. If we cannot find a good solution to this, maybe we can eliminate this section. Here is my thinking:
What do you think @sdiazlor @davidberenstein1957 ? |
@nataliaElv I think we can keep it assuming the next sentence is correct. We filter on startswith v2 to avoid potential other issues showing up so this wouldn't require any updates until v3, correct @sdiazlor? I agree we can find issues and milestones on GH but not everyone is as familiar with using open-source GH so it might be a good indirect funnel to guide people there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the discussion I would personally accept.
@nataliaElv @davidberenstein1957 Yes, "v2" doesn't need to be updated until "v3". The reason to filter it is that, in descending order, the first milestones are shown, so it would show the 1.x first (some are still open). |
I'm just saying that we should find a solution for future versions for these reasons:
|
Anyway, we can merge this change and find a solution later on 🙂 |
@nataliaElv Then, maybe you're referring more to the roadmap? But then they can go to that page, that's why I believe they are different things. Or, in any case, instead of the planned issues in detail, add the roadmap issues ¿? |
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
for more information, see https://pre-commit.ci
Pull Request Template
Closes #5116
CONSIDERATIONS:
I removed an API call as I found a key to determine if a member of the org/repo opened the issue (pre-commit should not be additionally added as previously because it only creates PRs, not issues). Locally, with a token with the permissions defined, it correctly removed the members.
Type of change
How Has This Been Tested
Checklist