Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Prepare theargilla-server package release #5039

Merged
merged 13 commits into from
Jun 18, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jun 17, 2024

Reviewing server build and release workflow.

  • Simplify docker image generation
  • Set image version from package version for releases
  • Align the release job with other workflows.

An example of successful action https://github.com/argilla-io/argilla/actions/runs/9560262017

@frascuchon frascuchon requested a review from jfcalvo June 18, 2024 07:21
PACKAGE_NAME=$(pdm show --name)
echo "PACKAGE_NAME=$PACKAGE_NAME" >> $GITHUB_OUTPUT
echo "PACKAGE_VERSION=$PACKAGE_VERSION" >> $GITHUB_OUTPUT
echo "$PACKAGE_NAME==$PACKAGE_VERSION"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this line doing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing relevant, just showing the configured name and version detected https://github.com/argilla-io/argilla/actions/runs/9560262017/job/26352268849#step:4:20.

@frascuchon frascuchon merged commit 762a1bf into releases/2.0.0-alpha0 Jun 18, 2024
6 checks passed
@frascuchon frascuchon deleted the ci/prepare-argilla-server-release branch June 18, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants