Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new argilla-server folder structure to README.md #4976

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jun 7, 2024

Description

In this PR I'm adding a small section to our README.md file with the new folder structure implemented.

@frascuchon I have checked too if it was possible to move /security folder to /api new folder structure but I think it should not be part of /api. In any case it should be moved to /context not sure if it's ok to move it right now as it is. (I have removed one file inside /security that was not used at all)

Refs #4868

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

  • Running tests.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon June 7, 2024 11:57
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.13%. Comparing base (d1bfec6) to head (9670a24).

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/v2.0.0    #4976       +/-   ##
================================================
+ Coverage        60.92%   92.13%   +31.21%     
================================================
  Files              329      135      -194     
  Lines            17674     5782    -11892     
================================================
- Hits             10767     5327     -5440     
+ Misses            6907      455     -6452     
Flag Coverage Δ
argilla ?
argilla-server 92.13% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit 2517cab into feat/v2.0.0 Jun 12, 2024
8 of 12 checks passed
@jfcalvo jfcalvo deleted the chore/add-new-server-structure-to-readme branch June 12, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants