-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notification component ui #48
Draft
bluecco
wants to merge
8
commits into
feat/react-components
Choose a base branch
from
feat/react-components-notifications
base: feat/react-components
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: notification component ui #48
bluecco
wants to merge
8
commits into
feat/react-components
from
feat/react-components-notifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-toast Feat/react components activity toast
bluecco
commented
Jan 2, 2024
bluecco
commented
Jan 2, 2024
bluecco
commented
Jan 2, 2024
import { CloseIcon } from "../../icons/CloseIcon" | ||
import { NotificationItem } from "./NotificationItem" | ||
|
||
// TODO: discuss structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vladutjs linked to the other comments, let's discuss this type too
bluecco
commented
Jan 2, 2024
…ications * feat/react-components: (32 commits) chore: address todo chore: update starknetkit on ui package and export components chore: remove old folder chore: remove wrong class chore: update stories and remove console log chore: use @argent/x-multicall package feat: add starknetkit to ConnectedButton component feat: add starknetId hook and helpers chore(release): 1.0.29 [skip ci] fix: add id for argent mobile modal overlay chore(release): 1.0.28 [skip ci] fix: add id for argent mobile modal container div chore(release): 1.0.27 [skip ci] fix: add part attribute for starknetkit modal for css override chore(release): 1.0.26 [skip ci] fix: don't show modal if only one connector is defined chore(release): 1.0.25 [skip ci] fix: rpc urls for mainnet chore: removed console log fix: allow custom provider for argent mobile connector ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.