-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/connect button updates #35
Conversation
@@ -0,0 +1,5 @@ | |||
import { Hex } from "../schemas/hexSchema" | |||
|
|||
export const uint256ToBigInt = (low: Hex, high: Hex): bigint => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do theoretically have this in starknet.js. Do we have that dependency in packages/ui
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do theoretically have this in starknet.js
I couldn't find this, but I'll check again when I'll work on this pr again
@vladutjs pr updated with tests, we should discuss for the notifications component (will be done in a followup pr) |
symbol: string | ||
} | ||
|
||
export function formatBalance( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use the same approach here as in argentx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checkout prettifyNumber
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, updated @vladutjs
No description provided.