-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: webwallet trpc #33
base: develop
Are you sure you want to change the base?
Conversation
@@ -49,12 +49,11 @@ export const setPopupOptions = ({ | |||
|
|||
// TODO: abstract AppRouter in order to have one single source of truth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: update the comment
@@ -68,44 +68,51 @@ export const StarknetMethodArgumentsSchemas = { | |||
z | |||
.object({ | |||
starknetVersion: z | |||
.union([z.literal("v4"), z.literal("v5")]) | |||
.union([z.literal("v3"), z.literal("v4")]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same question as @vladutjs here
No description provided.