Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use graphql-executor #4066

Merged
merged 3 commits into from
Jan 9, 2022
Merged

use graphql-executor #4066

merged 3 commits into from
Jan 9, 2022

Conversation

yaacovCR
Copy link
Collaborator

@yaacovCR yaacovCR commented Jan 4, 2022

Ready for review

@changeset-bot
Copy link

changeset-bot bot commented Jan 4, 2022

🦋 Changeset detected

Latest commit: b6cfed2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/utils Patch
@graphql-tools/import Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 4, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-tools/6sangN3gZHiaQoQryRhG33F4m5dr
✅ Preview: https://graphql-tools-git-use-graphql-executor-theguild.vercel.app

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jan 4, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@graphql-tools/batch-delegate@8.2.4-alpha-b935d9b2.0
@graphql-tools/batch-execute@8.3.2-alpha-b935d9b2.0
@graphql-tools/delegate@8.4.4-alpha-b935d9b2.0
@graphql-tools/graphql-tag-pluck@7.1.5-alpha-b935d9b2.0
graphql-tools@8.2.1-alpha-b935d9b2.0
@graphql-tools/import@6.6.5-alpha-b935d9b2.0
@graphql-tools/links@8.2.2-alpha-b935d9b2.0
@graphql-tools/load@7.5.2-alpha-b935d9b2.0
@graphql-tools/apollo-engine-loader@7.2.2-alpha-b935d9b2.0
@graphql-tools/code-file-loader@7.2.4-alpha-b935d9b2.0
@graphql-tools/git-loader@7.1.3-alpha-b935d9b2.0
@graphql-tools/github-loader@7.2.2-alpha-b935d9b2.0
@graphql-tools/graphql-file-loader@7.3.4-alpha-b935d9b2.0
@graphql-tools/json-file-loader@7.3.4-alpha-b935d9b2.0
@graphql-tools/module-loader@7.1.2-alpha-b935d9b2.0
@graphql-tools/prisma-loader@7.1.2-alpha-b935d9b2.0
@graphql-tools/url-loader@7.7.1-alpha-b935d9b2.0
@graphql-tools/merge@8.2.2-alpha-b935d9b2.0
@graphql-tools/mock@8.5.2-alpha-b935d9b2.0
@graphql-tools/node-require@6.3.2-alpha-b935d9b2.0
@graphql-tools/relay-operation-optimizer@6.4.2-alpha-b935d9b2.0
@graphql-tools/resolvers-composition@6.4.2-alpha-b935d9b2.0
@graphql-tools/schema@8.3.2-alpha-b935d9b2.0
@graphql-tools/stitch@8.4.4-alpha-b935d9b2.0
@graphql-tools/stitching-directives@2.2.2-alpha-b935d9b2.0
@graphql-tools/utils@8.6.1-alpha-b935d9b2.0
@graphql-tools/wrap@8.3.4-alpha-b935d9b2.0

@yaacovCR
Copy link
Collaborator Author

yaacovCR commented Jan 7, 2022

This surfaced some fixes on the executor side as well as some issues here, see #4088 and #4087.

This PR now depends on #4089, the fix for #4088, and when #4089 is presumably merged first, we can rebase this PR.

#4087 can be fixed independently.

@yaacovCR yaacovCR requested a review from ardatan January 7, 2022 08:26
@ardatan ardatan merged commit 72be8b0 into master Jan 9, 2022
@ardatan ardatan deleted the use-graphql-executor branch January 9, 2022 13:54
@yaacovCR
Copy link
Collaborator Author

@ardatan i see this pulled in some extraneous lockfile changes, not sure why/how, should we revert that part?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants