fix(utils): print specifiedBy directive correctly

ardatan · Aug 31, 2021 · 3f6ec05 · 3f6ec05
1 parent be6fdb8
commit 3f6ec05
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/rare-beds-report.md b/.changeset/rare-beds-report.md
@@ -0,0 +1,5 @@
+---
+'@graphql-tools/utils': patch
+---
+
+fix(utils): print specifiedBy directive correctly
diff --git a/packages/utils/src/print-schema-with-directives.ts b/packages/utils/src/print-schema-with-directives.ts
@@ -471,7 +471,10 @@ export function astFromScalarType(
     ? makeDirectiveNodes(schema, directivesInExtensions)
     : (type.astNode?.directives as DirectiveNode[]) || [];
 
-  if ('specifiedBy' in type && !directives.some(directiveNode => directiveNode.name.value === 'specifiedBy')) {
+  if (
+    (type as any)['specifiedByUrl'] &&
+    !directives.some(directiveNode => directiveNode.name.value === 'specifiedBy')
+  ) {
     const specifiedByArgs = {
       url: (type as any)['specifiedByUrl'],
     };

diff --git a/packages/utils/tests/print-schema-with-directives.spec.ts b/packages/utils/tests/print-schema-with-directives.spec.ts
@@ -212,7 +212,11 @@ describe('printSchemaWithDirectives', () => {
 
     const output = printSchemaWithDirectives(schema);
 
-    expect(output).toContain('scalar JSON');
+    if ('specifiedByUrl' in GraphQLJSON) {
+      expect(output).toContain(`scalar JSON @specifiedBy(url: ${(GraphQLJSON as any).specifiedByUrl})`);
+    } else {
+      expect(output).toContain('scalar JSON');
+    }
     expect(output).toContain('type Other');
     expect(output).toContain('type TestType');
     expect(output).toContain('type Query');