Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(omnigraph): make @transport repeatable #7198

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 2, 2024

When using bare merging which is basically regular schema merging compared to stitching, @transport directive can exist on schema multiple times.
And this makes the merged schema invalid so @transport needs to be repeatable.

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-mesh/json-schema 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@graphql-mesh/mysql 0.99.2-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@graphql-mesh/openapi 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@graphql-mesh/raml 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@omnigraph/json-schema 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@omnigraph/mysql 0.3.2-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@omnigraph/openapi 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎
@omnigraph/raml 0.101.3-alpha-20240702134651-a52b3aca37d7e320b11871aad4c0f668cebed4ae npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 2, 2024

💻 Website Preview

The latest changes are available as preview in: https://baea5865.graphql-mesh.pages.dev

@dr3
Copy link
Contributor

dr3 commented Jul 3, 2024

Thanks for the speedy fix! LGTM locally, correctly see

directive @transport(subgraph: String, kind: String, location: String, headers: [[String]], queryStringOptions: ObjMap, queryParams: [[String]]) repeatable on SCHEMA

in my schema and graphql validate is happy

@ardatan ardatan merged commit bdefa6f into master Jul 3, 2024
23 checks passed
@ardatan ardatan deleted the transport-repeatable branch July 3, 2024 10:50
ardatan added a commit that referenced this pull request Jul 9, 2024
* fix(omnigraph): make `@transport` repeatable

* Fix integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants