Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme appears to be broken on latest Insiders build #5

Closed
Plailect opened this issue Mar 11, 2017 · 2 comments
Closed

Theme appears to be broken on latest Insiders build #5

Plailect opened this issue Mar 11, 2017 · 2 comments

Comments

@Plailect
Copy link

Plailect commented Mar 11, 2017

On the latest Insiders build (1.11.0-insider, commit 01091bb), the theme seems to only change some colors. I've been using it successfully for several weeks up until it broke a few (?) days ago.

For reference, here are two screenshots comparing the default theme and Nord:

image

image

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Mar 12, 2017

Thanks for your report 👍
Well, since the Insiders version is a development build things may break everytime 😉

There are issues like Microsoft/vscode #22463 and Microsoft/vscode #22361 about this behavior which are already fixed in 56bbea94 and 0e5b61e8.

I've done a small research through the commits and it seems like they are implementing a whole new theming API which uses JSON as theme format instead of tmTheme (color scheme validation).

I think this is the preparation to provide a way to style the whole VS Code UI like the workbench sidebar, status bar and other UI elements which are currently not customizable via themes.

@Plailect
Copy link
Author

This appears to be fixed in latest Insiders commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants