Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect background color for themes on insiders build #22463

Closed
fzxt opened this issue Mar 11, 2017 · 6 comments
Closed

Incorrect background color for themes on insiders build #22463

fzxt opened this issue Mar 11, 2017 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) themes Color theme issues

Comments

@fzxt
Copy link

fzxt commented Mar 11, 2017

Hello,

The background color for some themes don't seem to be showing correctly.

Consider the screenshot shown on this theme:

image

VSCode insiders after installing and selecting theme:

image

It seems to be working fine on the non-insider version, though:
image

I've tried disabling all extensions and enabling only desired themes to make sure no extensions are messing with it, as well as adjusting the background color in the .tmTheme of individual themes themselves, but neither helped.

  • VSCode Version: Code - Insiders 1.11.0-insider (01091bb, 2017-03-10T07:05:03.565Z)
  • OS Version: Darwin x64 16.5.0
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.6.0
vscode-todo MattiasPernhult 0.8.0
vscode-wakatime WakaTime 1.1.3
project-manager alefragnani 0.13.3
vscode-color anseki 0.2.3
code-gnu-global austin 0.2.1
path-intellisense christian-kohler 1.2.0
vscode-eslint dbaeumer 1.2.7
vscode-instant-markdown dbankier 1.0.0
githistory donjayamanne 0.1.5
python donjayamanne 0.5.9
theme-dracula dracula-theme 1.2.5
vscode-babel-coloring dzannotti 0.0.4
file-icons file-icons 1.0.3
auto-rename-tag formulahendry 0.0.11
Theme-80s-pastel-dark fzxt 0.0.1
Theme-Solarized-ocean gerane 0.0.2
Theme-Zenburn gerane 0.0.3
Angular2 johnpapa 2.0.3
vs-color-picker lihui 0.6.0
markdown-shortcuts mdickin 0.6.1
vscode-elixir mjmcloug 0.1.1
cpptools ms-vscode 0.10.2
debugger-for-chrome msjsdiag 2.5.4
color-highlight naumovs 1.3.2
indent-rainbow oderwat 0.4.1
Ruby rebornix 0.10.4
vscode-icons robertohuertasm 7.3.0
sass-indented robinbentley 1.3.0
theme-gruvbox saviorisdead 0.0.1
theme-cobalt0 sharksym 0.0.5
bootstrap-3-snippets wcwhitehead 0.0.9

Steps to Reproduce:

  1. Install a theme
  2. Look at the background color
@ramya-rao-a ramya-rao-a added the themes Color theme issues label Mar 11, 2017
@ramya-rao-a
Copy link
Contributor

cc @alexandrudima

@jdc-cunningham
Copy link

Hi, I just wanted to ask, what is that color-start-end bands that you have for the code blocks?

@arcticicestudio
Copy link

I think this is a duplicate of #22361 which has already been fixed.

@fzxt
Copy link
Author

fzxt commented Mar 12, 2017

@jdc-cunningham
Copy link

@fzxt

Thank you

@ramya-rao-a
Copy link
Contributor

Thanks @arcticicestudio
Closing as duplicate go #22361
The next Insiders build on Monday will have the fix.

@ramya-rao-a ramya-rao-a assigned alexdima and unassigned aeschli Mar 12, 2017
@ramya-rao-a ramya-rao-a added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 12, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) themes Color theme issues
Projects
None yet
Development

No branches or pull requests

6 participants