Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11120 - File Widget: Indicate clearly All formats are allowed if no specific format is defined #11330

Merged

Conversation

csmith-he
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Allowed document formats text indicates all formats are acceptable if no specific format is defined - uses the allFormatsAccepted value in translatons

Issues Solved

#11120

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

Further comments

Targetting dev/7.5.x as requested for Arches for HERs

@csmith-he csmith-he added the bug label Aug 13, 2024
@csmith-he csmith-he requested a review from chiatt August 13, 2024 15:01
@csmith-he csmith-he linked an issue Aug 13, 2024 that may be closed by this pull request
@csmith-he
Copy link
Contributor Author

@chiatt - this is the ticket I mentioned on Tuesday. Would you be able to take a look at it?

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit d76c057 into archesproject:dev/7.5.x Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allowed document formats: undefined in File widget
2 participants