Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11117 bulk concept editor #11159

Merged
merged 57 commits into from
Sep 11, 2024
Merged

11117 bulk concept editor #11159

merged 57 commits into from
Sep 11, 2024

Conversation

apeters
Copy link
Member

@apeters apeters commented Jul 9, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Closes #11117

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

Further comments

vouidaskis and others added 2 commits July 4, 2024 09:59
@vouidaskis
incorporation of bulk concept edit script
fd9d966
@apeters
Merge pull request #11134 from vouidaskis/bulk_concept_editor_base_br…
f3e339d 
…anch

incorporation of bulk concept edit script into base PR branch for further editing
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

apeters and others added 27 commits July 10, 2024 14:09
@apeters
black lints, re #11117
2aad10d
@apeters
rename task method, re #11117
bd96f38
@apeters
simplify various method calls re #11117
bb108c9
@apeters
update UI and add new concept dropdowns, re #11117
0b60a7c
@apeters
get to a working UI, re #11117
e224c7a
@apeters
allow language to be passed into the paged concept dropdown widget, re …
2615806 
…#11117
@apeters
dispose of ko subscriptions when the selectwoo widget is destroyed, re …
e0b7d52 
…#11117
@apeters
starting down the path of refactoring concept bulk editor , re #11117
18a971a
@apeters
Merge branch 'dev/7.6.x' into 11117_bulk_concept_editor
2710e9a
@apeters
fix preview to use search instead of database, re #11117
3f2ccfb
@njkim
Add/update inconsistent variables, #11117
30f611e
@njkim
Update module to use bulk editor pattern, #11117
98ec3e1
@njkim
Use parameter dictionary, #11117
d622bfe
@njkim
Fix the sql casting, #11117
054ec1f
@apeters
send tiles to remove, remove many unneeded vars, re #11117
bb40de4
@apeters
fix UI issue, re #11117
c420477
@apeters
streamline preview method, re #11117
0ff402c
@apeters
make sure to reset the page index when doing a new query, re #11117
753e3ba
@njkim
Add help template, #11117
b3262ac
@njkim
Add migration, #11117
b0e3866
@njkim
Implement the new functions, #1117
7a23de4
@njkim
Add tileids, resourceids to edit & cleanup params list, #11117
6b7c579
@njkim
Re-use request for async process, #11117
a2a8206
@njkim
Assign empty list for tileids and resourceids, #11117
18d595f
@njkim
Add updateLimit to module config, #11117
818a675
@apeters
Merge branch 'dev/7.6.x' into 11117_bulk_concept_editor
e942fc1
@njkim
Add resource / tile query, #11117
a80660a
@njkim njkim marked this pull request as ready for review August 6, 2024 19:12
apeters
apeters commented Aug 8, 2024
View reviewed changes
Copy link
Member Author

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should resolve the graph and node id to human readable names.
Screenshot 2024-08-08 at 2 27 43 PM

apeters
apeters commented Aug 27, 2024
View reviewed changes
Copy link
Member Author

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me and the functionality has been approved by Getty Digital

@apeters apeters requested a review from chiatt August 27, 2024 20:46
chiatt
chiatt requested changes Aug 27, 2024
View reviewed changes
arches/app/templates/views/components/etl_modules/bulk_edit_concept.htm Outdated
<div class="etl-module-component-container">
<div class="etl-module-body">
<h2>
<span style="font-weight: 400; font-size: 1.7rem; color: #565656;">Replace Concept</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this and several other strings in this template could be in trans tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, those items should be resolved @chiatt

@chiatt chiatt self-assigned this Aug 29, 2024
@chiatt chiatt merged commit 656dd6c into dev/7.6.x Sep 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chiatt chiatt chiatt approved these changes

Assignees

@chiatt chiatt

Labels
Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@apeters @CLAassistant @chiatt @vouidaskis @njkim @jacobtylerwalls