Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for report height scrolling issue #11125

Conversation

phudson-he
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

This will fix an issue where when viewing on a device with a smaller available height, and the user would not be able to scroll down far enough to view all of the content. As said in the issue, this was identified while working on a aher ticket, where a hotfix was applied and will be removed once this is in core etc.

Issues Solved

Closes #11124

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

@aj-he
Copy link
Contributor

aj-he commented Jul 3, 2024

@phudson-he - that reportSummary class is not in core Arches. You should double check you included everything you need

@phudson-he
Copy link
Contributor Author

Yes indeed that should be included, thanks for spotting, working on it now

@phudson-he
Copy link
Contributor Author

CSS implemented for class .reportSummary. Although this doesn't look like it would do anything as the .resource-component-abstract class already has overflow-y: auto, this is required when using aher. It does not affect anything else, just re-affirms the overflow-y value.

@aj-he
Copy link
Contributor

aj-he commented Jul 4, 2024

This PR is being tracked here... archesproject/arches-her#1246

@aj-he aj-he marked this pull request as draft July 5, 2024 15:15
@aj-he
Copy link
Contributor

aj-he commented Jul 5, 2024

converted to draft to resolve erroneous commit.

… resource/qa filter dropdowns"

This reverts commit 171db68.
@aj-he aj-he marked this pull request as ready for review July 5, 2024 15:24
@chiatt
Copy link
Member

chiatt commented Jul 11, 2024

@phudson-he I haven't been able to reproduce #11124. Looking at this this report, there doesn't seem to be a problem scrolling to all of the content of the report. Even simulating an iPhone in landscape, I can get to the bottom of the content.

image

Is there a particular model and report tab where you are seeing it?

@phudson-he
Copy link
Contributor Author

Thanks @chiatt, I will take another look

@phudson-he
Copy link
Contributor Author

@chiatt I'm still re-looking at this, but just to be clear it's more to do with scrolling to the bottom of the details (from Details link) report view, rather than the default report view.

@chiatt
Copy link
Member

chiatt commented Jul 19, 2024

Thanks @phudson-he, I'll take a close look at the details.

@phudson-he
Copy link
Contributor Author

Closing this as it's an arches-her issue and was fixed with this: archesproject/arches-her#1284

@phudson-he phudson-he closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants