-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for report height scrolling issue #11125
Fix for report height scrolling issue #11125
Conversation
@phudson-he - that |
Yes indeed that should be included, thanks for spotting, working on it now |
CSS implemented for class .reportSummary. Although this doesn't look like it would do anything as the .resource-component-abstract class already has overflow-y: auto, this is required when using aher. It does not affect anything else, just re-affirms the overflow-y value. |
This PR is being tracked here... archesproject/arches-her#1246 |
converted to draft to resolve erroneous commit. |
… resource/qa filter dropdowns" This reverts commit 171db68.
@phudson-he I haven't been able to reproduce #11124. Looking at this this report, there doesn't seem to be a problem scrolling to all of the content of the report. Even simulating an iPhone in landscape, I can get to the bottom of the content. Is there a particular model and report tab where you are seeing it? |
Thanks @chiatt, I will take another look |
@chiatt I'm still re-looking at this, but just to be clear it's more to do with scrolling to the bottom of the details (from Details link) report view, rather than the default report view. |
Thanks @phudson-he, I'll take a close look at the details. |
Closing this as it's an arches-her issue and was fixed with this: archesproject/arches-her#1284 |
Types of changes
Description of Change
This will fix an issue where when viewing on a device with a smaller available height, and the user would not be able to scroll down far enough to view all of the content. As said in the issue, this was identified while working on a aher ticket, where a hotfix was applied and will be removed once this is in core etc.
Issues Solved
Closes #11124
Checklist
Ticket Background