-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10787 search export as system values #10789
Conversation
…rt concepts as uuids, w transltns, re #10787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, but would be much better concept specific but rather apply to all datatypes. That would eliminate the need for datatype checking and allow for future and custom datatypes to control how data is exported.
The boolean variable could be 'Export System Value' and then in search_export
the boolean would just determine whether 'get_display_value' or 'transform_export_values' is called.
…temvalues in ko vm, trans, and search-export re #10787
fix in latest |
FWIW coverage "failed" because of this delta: |
…pt_uuids merges latest from dev/7.6.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
node_value = datatype.get_display_value(tile, node) | ||
if self.export_system_values: | ||
node_value = datatype.transform_export_values( | ||
value, **{"concept_export_value_type": "id"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note - 'concept_export_value_type' is used here because that's the argument in both the domain and concept datatypes. Might be nice to use something more generic in the controlled list manager.
Types of changes
Description of Change
This PR enables exported search results to be rendered as their "system values", i.e. the node value comes from
datatype.transform_export_values()
instead ofdatatype.get_display_value()
. For exmaple concepts would render as their uuids instead of preflabels. It has a minor addition to the UI as well.Issues Solved
#10787
Checklist
Ticket Background
Further comments