Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project's core arches dependency range defined in two places #11114

Closed
jacobtylerwalls opened this issue Jul 1, 2024 · 1 comment · Fixed by #11189
Closed

Project's core arches dependency range defined in two places #11114

jacobtylerwalls opened this issue Jul 1, 2024 · 1 comment · Fixed by #11189
Assignees

Comments

@jacobtylerwalls
Copy link
Member

Defining a project-level dependency in core arches can happen in two places:

  • pyproject.toml, as of 7.6
  • settings.py: MIN_ARCHES_VERSION, and MAX_ARCHES_VERSION

Instead of having this in two places, which can cause drift, we could move the check in compatibility.py out of template rendering and into a Django system check. This probably still has value as a check, since not every developer pip install's their own projects, especially if they're not redistributing their app as a reusable app or doing custom development, or using GitHub etc.

If the check is defined at the project level, we can put it in the apps.py that will exist as of #11016.

@jacobtylerwalls jacobtylerwalls self-assigned this Jul 15, 2024
jacobtylerwalls added a commit that referenced this issue Jul 15, 2024
jacobtylerwalls added a commit that referenced this issue Jul 15, 2024
jacobtylerwalls added a commit that referenced this issue Jul 15, 2024
jacobtylerwalls added a commit that referenced this issue Jul 19, 2024
jacobtylerwalls added a commit that referenced this issue Jul 19, 2024
jacobtylerwalls added a commit that referenced this issue Jul 19, 2024
jacobtylerwalls added a commit that referenced this issue Aug 2, 2024
jacobtylerwalls added a commit that referenced this issue Aug 2, 2024
jacobtylerwalls added a commit that referenced this issue Aug 2, 2024
jacobtylerwalls added a commit that referenced this issue Aug 2, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
chiatt pushed a commit that referenced this issue Aug 6, 2024
@jacobtylerwalls
Copy link
Member Author

Fixed in #11189

jacobtylerwalls added a commit that referenced this issue Aug 6, 2024
jacobtylerwalls added a commit that referenced this issue Aug 6, 2024
jacobtylerwalls added a commit that referenced this issue Aug 6, 2024
jacobtylerwalls added a commit that referenced this issue Aug 6, 2024
jacobtylerwalls added a commit that referenced this issue Aug 8, 2024
chiatt pushed a commit that referenced this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant