[#242] outputの動画のrange指定機能修正 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
ver1.1へマージ予定。
algorithmのoutputにImageDataを含み、かつそのデータが動画(ndim==3)の場合について、jsonではなくtiffファイルのパスをoutput_pathとして設定するように修正
これによって、VISUALIZE Plotでindex指定した際に指定の範囲でのjsonが生成されるようになる。
デフォルトの範囲は0 ~ 10で、json生成済の範囲の場合は再参照する方式なので処理が軽減される。
その他、各関数への影響確認中にsuite2p_spike_deconvでNWB保存の際のエラーが発覚したため本PR内で修正。（NWBへfunction_id単位でデータを保存する対応の際に漏れていた模様。）