Frontend Build Instructions #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cw00dw0rd
commented
Apr 29, 2020
cw00dw0rd
commented
- Updated the maintaner.md as it already contained build information. Could be placed somewhere else though.
- May be worthwhile to move any discussion of frontend interaction to the frontend folder. Could offer maintainer information for frontend contributors and have the build steps there instead.
joerg84
reviewed
Apr 29, 2020
documentation/build/maintainer.md
Outdated
| @@ -79,4 +86,27 @@ Edit the the `makefile` to make the following changes: | |||
| 3. Run `make docker_APSI_build` | |||
|
|
|||
|
|
|||
| ### Building only the ArangoML WebUI | |||
There was a problem hiding this comment.
Maybe match the TOC entry
Building a frontend-only Docker image for the ArangoML WebUI
joerg84
reviewed
Apr 29, 2020
documentation/build/maintainer.md
Outdated
|
|
||
| 2. Run `docker-compose build Dockerfile` | ||
|
|
||
| 3. Run `docker run -p 3000:3000 -p 6529:8529 -it arangopipe_frontend_app` |
There was a problem hiding this comment.
Why do we need -p 6529:8529?
joerg84
reviewed
Apr 29, 2020
documentation/build/maintainer.md
Outdated
|
|
||
| 6. `exit` | ||
|
|
||
| 7. Run `docker restart` |
There was a problem hiding this comment.
IMo this is not nice, can we just restart the node app
joerg84
reviewed
Apr 29, 2020
documentation/build/maintainer.md
Outdated
|
|
||
| 3. Run `docker ps` to obtain container Name/ID | ||
|
|
||
| 4. Run `docker exec -it {Container Name/ID} sh` |
There was a problem hiding this comment.
Can we simplify this by setting the env variable via -e on docker run
joerg84
reviewed
Apr 29, 2020
documentation/build/maintainer.md
Outdated
| The following instructions show you how to build the different supported packages. | ||
| These instructions include build instructions for: | ||
| * Building Arangopipe package | ||
| * Building Arangopipe Docker Images with Tensorflow & PyTorch |
joerg84
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.