#42: Command /autopause
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsojramos
approved these changes
Jan 22, 2022
Merged
aquelemiguel
approved these changes
Jan 22, 2022
There was a problem hiding this comment.
Looks great, I like your refactoring of the /events dir.
A behaviour went against my intuition: skipping an autopaused song also pauses the next one. From what I've investigated, there's no simple way to check whether the track was paused before being skipped. Let's revisit this later if after using it for a while we find it that frustrating.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/autopauseas a toggle, similar to/repeat.Make use of serenity's context cache to store
GuildSettingssuch as theautopauseflag. @aquelemiguel will be using it for other Guild-related cache.Tested the edge cases of skipping and seeking to the end of the track with autopause on.