Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] SOAR-0012 Generate enums for server variables #629

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Proposal] SOAR-0012 Generate enums for server variables #629

wants to merge 4 commits into from

Conversation

theoriginalbit
Copy link

Motivation

As requested by @czechboy0 in #618 I have created this proposal for community feedback.

Modifications

Added the proposal.

Also fixed a typo in the document for the proposal process.

Result

N/A

Test Plan

N/A

@czechboy0
Copy link
Collaborator

Whoops, SOAR-0011 is already taken, please use SOAR-0012 :) #626

@czechboy0
Copy link
Collaborator

Looks good overall, almost ready to go into review. Could you just slightly elaborate on the behavior with the feature flag enabled/disabled in the API stability section? Right now it sounds like it could be API breaking even for folks who don't opt-in, which isn't the case.

@theoriginalbit theoriginalbit force-pushed the proposal/generate-server-variable-enums branch from 9abfdfd to 663dbcd Compare September 18, 2024 22:53
@theoriginalbit
Copy link
Author

Whoops, SOAR-0011 is already taken, please use SOAR-0012 :) #626

Fixed :)

@theoriginalbit theoriginalbit changed the title [Proposal] SOAR-0011 Generate enums for server variables [Proposal] SOAR-0012 Generate enums for server variables Sep 18, 2024
@theoriginalbit
Copy link
Author

Looks good overall, almost ready to go into review. Could you just slightly elaborate on the behavior with the feature flag enabled/disabled in the API stability section? Right now it sounds like it could be API breaking even for folks who don't opt-in, which isn't the case.

Done :)

@theoriginalbit theoriginalbit mentioned this pull request Sep 18, 2024
Open
czechboy0
czechboy0 requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@czechboy0 czechboy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more nits, after that I'm happy to send this into review.

Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0012.md Outdated Show resolved Hide resolved
Sources/swift-openapi-generator/Documentation.docc/Proposals/SOAR-0012.md Outdated Show resolved Hide resolved
@czechboy0 czechboy0 added the kind/proposal Proposals for review. label Sep 19, 2024
@czechboy0
Copy link
Collaborator

This proposal is now In Review, forums thread: https://forums.swift.org/t/proposal-soar-0012-generate-enums-for-server-variables/74737

@theoriginalbit theoriginalbit force-pushed the proposal/generate-server-variable-enums branch from 8960a5a to 777db9c Compare October 1, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czechboy0 czechboy0 czechboy0 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
kind/proposal Proposals for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theoriginalbit @czechboy0