Only show disk space warning when files are actually being uploaded #552
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes for handling the preparation of upgrades.
Currently, there's is a disk space warning that is triggered if sdpctl detects that an appliance has low disk space. This is to make sure that the appliances has enough disk space to handle the uploads.
The disk space warning, however, does not take into consideration that uploads may be skipped if the file already exists on the appliance, making it obsolete if no files are actually being uploaded.
This PR fixes this by moving the disk space warning check until after we know that files need to be uploaded.