[SA-22192] Validate user input when user provides a pem file #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fails because of #442 |
dlnilsson
added a commit
that referenced
this pull request
Jul 17, 2023
this PR is built on top of #443 where we already parse the certificate during user input for validation pem_filepath can be removed in the future, but removing it right now would break backwards compability, we might want to add migration logic for this.
make sure user input is acctually a PEM file, see Youtrack ticket for more info.
kajes
approved these changes
Aug 15, 2023
kajes
pushed a commit
that referenced
this pull request
Aug 16, 2023
this PR is built on top of #443 where we already parse the certificate during user input for validation pem_filepath can be removed in the future, but removing it right now would break backwards compability, we might want to add migration logic for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make sure user input is acctually a PEM file, see Youtrack ticket for more info.