Use const for skipAuthCheck annotation

appgate · Jun 23, 2023 · 8b70df8 · 8b70df8
1 parent 711d7dc
commit 8b70df8
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 7 deletions.
diff --git a/cmd/completion.go b/cmd/completion.go
@@ -13,7 +13,7 @@ func NewCmdCompletion() *cobra.Command {
 	var completionCmd = &cobra.Command{
 		Use: "completion [bash|zsh|fish|powershell]",
 		Annotations: map[string]string{
-			"skipAuthCheck": "true",
+			configuration.SkipAuthCheck: "true",
 		},
 		Short:     docs.CompletionDocs.Short,
 		Long:      docs.CompletionDocs.Long,

diff --git a/cmd/configure/configure.go b/cmd/configure/configure.go
@@ -38,7 +38,7 @@ func NewCmdConfigure(f *factory.Factory) *cobra.Command {
 	cmd := &cobra.Command{
 		Use: "configure",
 		Annotations: map[string]string{
-			"skipAuthCheck": "true",
+			configuration.SkipAuthCheck: "true",
 		},
 		Short:   docs.ConfigureDocs.Short,
 		Long:    docs.ConfigureDocs.Long,

diff --git a/cmd/configure/signin.go b/cmd/configure/signin.go
@@ -2,6 +2,7 @@ package configure
 
 import (
 	"fmt"
+	"github.com/appgate/sdpctl/pkg/configuration"
 	"io"
 	"os"
 
@@ -27,7 +28,7 @@ func NewSigninCmd(f *factory.Factory) *cobra.Command {
 	var signinCmd = &cobra.Command{
 		Use: "signin",
 		Annotations: map[string]string{
-			"skipAuthCheck": "true",
+			configuration.SkipAuthCheck: "true",
 		},
 		Aliases: []string{"login"},
 		Short:   docs.ConfigureSigninDocs.Short,

diff --git a/cmd/generate.go b/cmd/generate.go
@@ -6,6 +6,7 @@ import (
 	"compress/gzip"
 	"errors"
 	"fmt"
+	"github.com/appgate/sdpctl/pkg/configuration"
 	"io"
 	"io/fs"
 	"os"
@@ -32,7 +33,7 @@ var generateCmd = &cobra.Command{
 	Aliases: []string{"gen"},
 	Hidden:  true,
 	Annotations: map[string]string{
-		"skipAuthCheck": "true",
+		configuration.SkipAuthCheck: "true",
 	},
 	DisableFlagsInUseLine: true,
 	ValidArgs:             []string{"man", "html", "all"},

diff --git a/cmd/open.go b/cmd/open.go
@@ -17,7 +17,7 @@ func NewOpenCmd(f *factory.Factory) *cobra.Command {
 	return &cobra.Command{
 		Use: "open",
 		Annotations: map[string]string{
-			"skipAuthCheck": "true",
+			configuration.SkipAuthCheck: "true",
 		},
 		Short: "Open the Admin UI in your browser",
 		RunE: func(c *cobra.Command, args []string) error {

diff --git a/cmd/profile/profile.go b/cmd/profile/profile.go
@@ -36,7 +36,7 @@ func NewProfileCmd(f *factory.Factory) *cobra.Command {
 	cmd := &cobra.Command{
 		Use: "profile",
 		Annotations: map[string]string{
-			"skipAuthCheck": "true",
+			configuration.SkipAuthCheck: "true",
 		},
 		TraverseChildren: true,
 		Short:            docs.ProfileRootDoc.Short,

diff --git a/pkg/configuration/configuration.go b/pkg/configuration/configuration.go
@@ -85,13 +85,15 @@ func DefaultDeviceID() string {
 	return v
 }
 
+const SkipAuthCheck = "skipAuthCheck"
+
 func IsAuthCheckEnabled(cmd *cobra.Command) bool {
 	switch cmd.Name() {
 	case "help", cobra.ShellCompRequestCmd, cobra.ShellCompNoDescRequestCmd:
 		return false
 	}
 	for c := cmd; c.Parent() != nil; c = c.Parent() {
-		if c.Annotations != nil && c.Annotations["skipAuthCheck"] == "true" {
+		if c.Annotations != nil && c.Annotations[SkipAuthCheck] == "true" {
 			return false
 		}
 	}