Update Swift operationIdentifier to be a String? rather than the …
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inferred `String`. This brings it in alignment with the `variables` property, whose default value is provided by its protocol as `nil`.
kompfner
pushed a commit
to kompfner/apollo-ios
that referenced
this pull request
Jul 10, 2017
kompfner
added a commit
to apollographql/apollo-ios
that referenced
this pull request
Jul 13, 2017
* Update dependency on apollo-codegen to 0.14, so we can make use of operationIds * Add support for sending operation ids rather than operation text when making requests * Handle `operationIdentifier`s being of type `String?` rather than `String` (see apollographql/apollo-tooling#167) * Update dependency on apollo-codegen to 0.15, so we can *actually* make use of `operationIdentifier`s (turns out they weren't ccorrectly made available in 0.14, as explained in apollographql/apollo-tooling#165)
ecstasy2
added a commit
to ecstasy2/apollo-codegen
that referenced
this pull request
Dec 22, 2017
…inferred `String`. This brings it in alignment with the `variables` property, whose default value is provided by its protocol as `nil`. (apollographql#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inferred
String. This brings it in alignment with thevariablesproperty, whose default value is provided by its protocol asnil.See discussion in apollographql/apollo-ios#105 for context.