Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language-server: Don't break on bad arguments #1523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

language-server: Don't break on bad arguments #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e763a0d
Don't break on bad arguments
kastermester Sep 11, 2019
4a5f64e
Include changelog entry for #1523
kastermester Sep 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
- <First `apollo-graphql` related entry goes here>
- `apollo-language-server`
- Replace instanceof checks with their respective predicates [#1518](https://github.com/apollographql/apollo-tooling/pull/1518)
- Language server should not break on hover provider over untyped arguments (https://github.com/apollographql/apollo-tooling/pull/1523)
- `apollo-tools`
- <First `apollo-tools` related entry goes here>
- `vscode-apollo`
Expand Down
3 changes: 2 additions & 1 deletion packages/apollo-language-server/src/languageProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,8 @@ export class GraphQLLanguageProvider {
}

case Kind.ARGUMENT: {
const argumentNode = typeInfo.getArgument()!;
const argumentNode = typeInfo.getArgument();
if (!argumentNode) break;
const content = [
[
`\`\`\`graphql`,
Expand Down