Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #656 #1464

Merged
merged 2 commits into from
Aug 7, 2019
Merged

Revert PR #656 #1464

merged 2 commits into from
Aug 7, 2019

Conversation

designatednerd
Copy link
Contributor

This PR reverts changes from #656, they were causing build issues on iOS and the originator is going to come up with a new reproduction before we take another stab at this.

This will need to go out as a patch release for swift and tooling since I 'm a moron got a little ahead of myself and didn't fully test these locally before getting them released.

@designatednerd
Copy link
Contributor Author

Note that it's +5 / -17 rather than +3 / -15 to match the other PR due to the update to the changelog.

@abernix abernix merged commit 36cea8e into master Aug 7, 2019
@abernix abernix deleted the revert/656 branch August 7, 2019 09:55
@abernix
Copy link
Member

abernix commented Aug 7, 2019

Released in the following packages.

Successfully published:                                                                                                    
 - apollo-codegen-swift@0.35.2                                                                                             
 - apollo@2.17.2 

essaji pushed a commit to essaji/apollo-tooling that referenced this pull request Aug 25, 2019
* Revert changes from apollographql#656 which were causing build issues on iOS

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants