Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Fix escaping of parameter and class names #1452

Merged
merged 6 commits into from
Jul 30, 2019

Conversation

designatednerd
Copy link
Contributor

This fix addresses iOS 193, where the name of the parameter was being escaped in a property, but the name of the type was not.

Also made sure the names of classes are being properly escaped, and the names of parameters on protocol property declarations.

Note: I've left the type unescaped on protocol properties purposely, because I'm not sure if we're using Self as a bound anywhere, and I'd like to fix the other stuff without breaking the crap out of that.

@designatednerd
Copy link
Contributor Author

Also threw in a couple tests so we can better check regressions on #1441. Merging.

@designatednerd designatednerd merged commit 851ea49 into master Jul 30, 2019
@designatednerd designatednerd deleted the ellen/fix-self branch July 30, 2019 21:35
@designatednerd designatednerd mentioned this pull request Jul 30, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant